maker-bundle icon indicating copy to clipboard operation
maker-bundle copied to clipboard

Published 20 hours ago • verified publisher icon symfony

[make:*] Fluent setters bundle configuration option

Open prugala opened this issue 5 years ago • 15 comments

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #297
License MIT

Based on #297

At the moment we cannot decide that we want to generate fluent or not fluent setters.

I read the discussion in an issue and I added global configuration option:

maker:
  fluent_setters: false // default: true

prugala avatar Jul 03 '19 16:07 prugala

Are you going to finish it @prugala?

maks-rafalko avatar Dec 28 '19 10:12 maks-rafalko

@maks-rafalko oh I forgot about it. Yes I will finish it. I will try to add tests and update docs this week.

prugala avatar Dec 28 '19 13:12 prugala

OK I added tests and updated doc section. @weaverryan could you look or call someone who can do it. Thanks :)

prugala avatar Dec 28 '19 16:12 prugala

Any news about this PR? What is it missing?

AlboCode avatar Sep 10 '20 09:09 AlboCode

@AlboCode I see conflicts, I will fix it tomorrow and will ask about merge :)

prugala avatar Sep 10 '20 20:09 prugala

@AlboCode I see conflicts, I will fix it tomorrow and will ask about merge :)

Thanks 👍

AlboCode avatar Sep 11 '20 10:09 AlboCode

Sorry for ping but PR is old and I forgot to end it before. Now its ready with tests.

@nicolas-grekas @weaverryan and docs change so @javiereguiluz :)

prugala avatar Sep 13 '20 20:09 prugala

This is just what I have been looking for. A must if we want to use maker in applications that have already defined non-fluent interfaces to implement on our entities (Sylius). How long would this typically take to be merged now that tests are passing?

acornforth avatar Oct 09 '20 11:10 acornforth

@BatsaxIV thank you again for review. I've added missing parameter there and in few other places. Now All "Manipulators" use custom parameter.

prugala avatar Oct 10 '20 12:10 prugala

Is there something holding this PR back?

hockdudu avatar Nov 04 '22 07:11 hockdudu

Is there something holding this PR back?

I resolve conflicts today later and I think all should be ready to merge :)

prugala avatar Nov 04 '22 11:11 prugala

Any chance to move this forward? Guys from my team refuse to use maker for entities because of forced fluent interface, which brings whole bunch of new troubles.

Yea, it is more about people than code, but this fluent_setters: false would help with people.-)

Thanks!

jaroslavtyc avatar Dec 07 '23 09:12 jaroslavtyc

Since its been some time with this PR, I'd like to take the chance and un-necro it before it gets stale over a year again.

I'd love to see this configuration being pushed to prod so that we can go back to non-fluent setters. Thanks everyone involved pushing this forward.

bytes-commerce avatar Jun 04 '24 07:06 bytes-commerce

Sorry to ping again. @prugala just in case you're still contributing to the project, I believe that many people would be happy to see your changes. If not, please let us know so that maybe someone else can take over from here on. :pray:

bytes-commerce avatar Jun 17 '24 15:06 bytes-commerce

@nopenopenope sorry for lack of activity. I'll update PR to current code base today or tomorrow :)

prugala avatar Jun 17 '24 17:06 prugala