swoole-bundle icon indicating copy to clipboard operation
swoole-bundle copied to clipboard
verified publisher icon symfony-swoole

feat(command): onRequest event,httpKernelRequestHandler, should wait …

Open pistej opened this issue 1 year ago • 5 comments

…until WorkerStart event is dispatched

Issue: #106

pistej avatar Mar 26 '24 14:03 pistej

@pistej thanks for the contribution! looks like there is something wrong with the POC, do you have any idea what that might be?

Rastusik avatar Mar 27 '24 15:03 Rastusik

no idea ... I'm glad this error is so explanatory ;) ... but assume smth. with phpunit test ?! ... wil look into it

pistej avatar Mar 27 '24 16:03 pistej

so seems my fix broke all tests :) ( seems like using coroutine before CoroutinePoolTest causes fail -> Scheduler which is tested ...:/ ) , I've tested my scenario with workers more, and seems all is working fine until you don't enable coroutines (+hooks), or use some coroutines functions, this is fine for now ... I would postpone this PR for now

Note: @Rastusik can u make a release with my latest fix ? Thx

pistej avatar Apr 05 '24 18:04 pistej

@pistej

can u make a release with my latest fix ?

I'll try this evening but I'm sick, so no promises...

Rastusik avatar Apr 09 '24 08:04 Rastusik

@Rastusik then no hurry, get well :)

pistej avatar Apr 09 '24 09:04 pistej

@pistej can I close this PR?

Rastusik avatar Sep 08 '24 15:09 Rastusik

@Rastusik yup, closed , will reopen, sometime, when hooks ... :rocket:

pistej avatar Sep 08 '24 15:09 pistej