seo-bundle icon indicating copy to clipboard operation
seo-bundle copied to clipboard

can't install with Seo sonata bundle 2.0.0

Open asennoussi opened this issue 9 years ago • 9 comments

symfony-cmf/seo-bundle 1.1.2 requires sonata-project/seo-bundle 1.1.* -> no matching package found.

asennoussi avatar Nov 23 '15 20:11 asennoussi

Caused by some heavy BC breaks between SonataSeo 1.* and 2.* we still keep that version. I think if would take some time to also use SonataSeo 2.*. You do need that SonataVersion?

ElectricMaxxx avatar Nov 23 '15 23:11 ElectricMaxxx

@ElectricMaxxx which BC breaks are you talking about? I don't see much: https://github.com/sonata-project/SonataSeoBundle/compare/1.1.10...2.0.0

wouterj avatar Dec 28 '15 13:12 wouterj

I have tried it with 2.0. but something was missing, when instantiating that bundle. Don't remember what. But will invest some Time to find it again.

ElectricMaxxx avatar Dec 28 '15 13:12 ElectricMaxxx

Mhh ... Indeed the changes are some only. And they seem to be not that dangourous. (Except the one in the suggest part of composer.json :-)

ElectricMaxxx avatar Dec 28 '15 14:12 ElectricMaxxx

i think we should change on 2.0

ElectricMaxxx avatar Feb 13 '16 20:02 ElectricMaxxx

Anything on this?

Warxcell avatar Jun 03 '16 16:06 Warxcell

I think we won't inteoduce SonataSeo on 1.*. WE will give it a Chance on our way into 2.0

Ping @wouterJ Right?

ElectricMaxxx avatar Jun 04 '16 09:06 ElectricMaxxx

Well, again, there is not much changed between 1.x and 2.0. We don't override the classes that changed the typehint and other changes are not included. This means it can easily be included in 1.2.1.

wouterj avatar Jun 04 '16 11:06 wouterj

Please note that master (2.0.0-dev) already support SonataSeoBundle 2.0.

wouterj avatar Jun 04 '16 12:06 wouterj