media-bundle
media-bundle copied to clipboard
investigate image/ file upload response
We abstracted the image / file upload for Create and other web editors in UploadFileHelper::getUploadResponse
.
The logic is currently ported from the CreateBundle and improved at some points. We should investigate the response more, questions raised are:
- I don't know much about how CkEditor works, so this may not be applicable, but shouldn't we be returning a "application/json" response and using a callback in the frontend to call functions rather than returning HTML? (dantleech)
- We now return javascript directly for the ckeditor but could investigate when we implement the ckeditor for the CreateBundle - possibly also in combination with elfinder.
- follow up of https://github.com/symfony-cmf/MediaBundle/pull/27#discussion_r5788934
- I wonder if it is a good idea to refer to an "editor" here. (in
UploadFileHelper::getUploadResponse
) Could we not use this upload thingy from a web form, or something else? (dantleech)- Can we think of a use case for this? (rmsint)
- Current logic is here because we expected the automatic upload process mostly for web editors.
- follow up of https://github.com/symfony-cmf/MediaBundle/pull/40#discussion_r5831139
@rmsint do you know more details about this one?
@lsmith77 added details to the issue description above
thx