eval-dev-quality icon indicating copy to clipboard operation
eval-dev-quality copied to clipboard
verified publisher icon symflower

`ollama_llama_server` and other background processes we start must be killed on CTRL+C

Open zimmski opened this issue 1 year ago • 3 comments

I just noticed that i had multiple ollama_llama_server running.

zimmski avatar Jun 06 '24 07:06 zimmski

@ahumenberger @Munsio don't think that this is a blocker, but please check the server too. I think we already fixed that with the Symflower binary somehow?

zimmski avatar Jun 06 '24 07:06 zimmski

I think we would never really notice with the Symflower binary because it is guaranteed to finish, while the Ollama server is supposed to be running all the time. I.e. even if we forgot to terminate Symflower properly, it would stop on it's own?

bauersimon avatar Jun 10 '24 06:06 bauersimon

https://stackoverflow.com/questions/33165530/prevent-ctrlc-from-interrupting-exec-command-in-golang

Seems like all sub-processes "should" be killed by default... but the aren't :see_no_evil:

bauersimon avatar Jun 13 '24 06:06 bauersimon