symbol-cli icon indicating copy to clipboard operation
symbol-cli copied to clipboard

Add test to command tables

Open dgarcia360 opened this issue 5 years ago • 2 comments

Command tables do not have unit tests. To solve this issue, we can move existent tables to a new views folder, and implement unit tests for every table.

dgarcia360 avatar Jan 21 '20 14:01 dgarcia360

Do you want to add more tests to tables? Such as signed transactions, or edge cases (no mosaics, etc)?

IMO it is already OK like that

decentraliser avatar Jan 30 '20 07:01 decentraliser

I would like to add tests to tables such as: https://github.com/nemtech/nem2-cli/blob/master/src/commands/metadata/account.ts#L34-L59 It might make sense to move them under the views folder as well.

dgarcia360 avatar Jan 30 '20 08:01 dgarcia360