desktop-wallet icon indicating copy to clipboard operation
desktop-wallet copied to clipboard

Offline transactions - invalid deadline calculation

Open cryptoBeliever opened this issue 1 year ago • 0 comments

What's the issue?

Desktop wallet calculates incorrect deadlines for offline transactions. This causes Failure_Core_Past_Deadline when announcing.

Example signed transaction:

B000000000000000692DE12C9BD80C5F00ECADCED4190C80FE18777F52C3279335B9FEF097F25E79B8933A7E1EE50993FD2646AE9C2E00F06E2A99D7FF3F6370BE135FBB7CF37F061E7D10805F25609A8E3A866F3ED05C5D9B307CD0DE220325B8DD1D6D9108DAB80000000001685441C0440000000000003E5A70550300000068805C51DF7DB65E75F23FA110B3C6A5F14AAB67DB6535050000010000000000F82302A23F91ED6B0000000000000000
(
  signature: 692DE12C9BD80C5F00ECADCED4190C80FE18777F52C3279335B9FEF097F25E79B8933A7E1EE50993FD2646AE9C2E00F06E2A99D7FF3F6370BE135FBB7CF37F06,
  signerPublicKey: 1E7D10805F25609A8E3A866F3ED05C5D9B307CD0DE220325B8DD1D6D9108DAB8,
  version: 0x1,
  network: NetworkType.MAINNET,
  type: TransactionType.TRANSFER,
  fee: 0x00000000000044C0,
  deadline: 0x0000000355705A3E,
  recipientAddress: 68805C51DF7DB65E75F23FA110B3C6A5F14AAB67DB653505,
  mosaics: [
    (
      mosaicId: 0x6BED913FA20223F8,
      amount: 0x0000000000000000,
    )
  ]
  message: hex(),
)

So the calculated deadline is 14318328382, but the current mainnet time is 65708508761.

What's the expected result?

Calculate timestamps/deadlines correctly, considering epoch adjustment.

Affected wallet versions: 1.0.12 and 1.0.13

cryptoBeliever avatar Apr 15 '23 12:04 cryptoBeliever