desktop-wallet icon indicating copy to clipboard operation
desktop-wallet copied to clipboard

[wallet/desktop] feat: unit test table display component

Open AnthonyLaw opened this issue 2 years ago • 1 comments

What was the issue?

  • missing unit test in the TableDisplay component.

What's the fix?

  • Added unit test TableDisplay component.
  • update mock data (metadata, namespace, mosaic)
  • minor refactor for removed setFilteredBy method

AnthonyLaw avatar Aug 23 '22 23:08 AnthonyLaw

Codecov Report

Merging #1901 (bf99670) into feature/unit-tests-united-2 (7c24073) will increase coverage by 1.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feature/unit-tests-united-2    #1901      +/-   ##
===============================================================
+ Coverage                        34.63%   35.78%   +1.15%     
===============================================================
  Files                              586      586              
  Lines                            14033    14028       -5     
  Branches                          2358     2358              
===============================================================
+ Hits                              4860     5020     +160     
+ Misses                            9107     8942     -165     
  Partials                            66       66              
Flag Coverage Δ
wallet-desktop 35.78% <100.00%> (+1.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/TableDisplay/TableDisplayTs.ts 97.97% <100.00%> (+59.41%) :arrow_up:
src/services/MosaicService.ts 68.64% <0.00%> (+1.69%) :arrow_up:
src/core/utils/Formatters.ts 42.37% <0.00%> (+5.08%) :arrow_up:
src/services/NamespaceService.ts 38.63% <0.00%> (+22.72%) :arrow_up:
...rc/services/AssetTableService/AssetTableService.ts 59.45% <0.00%> (+27.02%) :arrow_up:
...c/services/AssetTableService/MosaicTableService.ts 100.00% <0.00%> (+84.21%) :arrow_up:
...ervices/AssetTableService/NamespaceTableService.ts 100.00% <0.00%> (+88.46%) :arrow_up:
...services/AssetTableService/MetadataTableService.ts 100.00% <0.00%> (+90.00%) :arrow_up:
src/components/TableDisplay/TableDisplay.vue 100.00% <0.00%> (+100.00%) :arrow_up:

codecov-commenter avatar Aug 23 '22 23:08 codecov-commenter