desktop-wallet icon indicating copy to clipboard operation
desktop-wallet copied to clipboard

Aggregate bonded sent from cosigner from multilevel multi-sig present as Unknown

Open cryptoBeliever opened this issue 3 years ago • 4 comments

Steps:

  1. Create multilevel multi-sig. For example:
Multilevel (2 of 2)
 	Multisig cosigner 1 (1 of 1)
 		Cosigner 1
 	Multisig cosigner 2 (1 of 1)
 		Cosigner 2
  1. Send transaction from Cosigner 1.
  2. Go to Cosigner 2 and open transaction details.

Result: There is a view like for Unknown signer but this signer is from a Known cosigner.

Expected result: We should not show an "unknown signer warning" and present flow as for a known accounts.

cryptoBeliever avatar Feb 20 '22 20:02 cryptoBeliever

I think we can use this method to determine if an address is in the current multi-sig tree:

https://github.com/symbol/desktop-wallet/blob/8b236aa7191776709a42c1c7bff50ff0a27c832f/src/services/MultisigService.ts#L180

yilmazbahadir avatar Feb 21 '22 09:02 yilmazbahadir

@yilmazbahadir thanks mate!

OlegMakarenko avatar Feb 21 '22 09:02 OlegMakarenko

@OlegMakarenko we are using currently this method: https://github.com/symbol/desktop-wallet/blob/3e3f46f184e4700e52fd4b5520b91dcdd6e3f510/src/views/modals/ModalTransactionCosignature/ModalTransactionCosignatureTs.ts#L263

The issue is related to https://github.com/symbol/desktop-wallet/issues/1849. When we call multisig/graph for cosigner not the entire tree is returned. We can use proposed fix here https://github.com/symbol/desktop-wallet/issues/1849 (additional call) to fetch entire tree.

cryptoBeliever avatar Feb 21 '22 13:02 cryptoBeliever

Fixed in https://github.com/symbol/desktop-wallet/pull/1847

cryptoBeliever avatar Feb 21 '22 17:02 cryptoBeliever

Released in 1.0.11

cryptoBeliever avatar Sep 19 '22 21:09 cryptoBeliever