desktop-wallet
desktop-wallet copied to clipboard
Aggregate bonded sent from cosigner from multilevel multi-sig present as Unknown
Steps:
- Create multilevel multi-sig. For example:
Multilevel (2 of 2)
Multisig cosigner 1 (1 of 1)
Cosigner 1
Multisig cosigner 2 (1 of 1)
Cosigner 2
- Send transaction from Cosigner 1.
- Go to Cosigner 2 and open transaction details.
Result: There is a view like for Unknown signer but this signer is from a Known cosigner.
Expected result: We should not show an "unknown signer warning" and present flow as for a known accounts.
I think we can use this method to determine if an address is in the current multi-sig tree:
https://github.com/symbol/desktop-wallet/blob/8b236aa7191776709a42c1c7bff50ff0a27c832f/src/services/MultisigService.ts#L180
@yilmazbahadir thanks mate!
@OlegMakarenko we are using currently this method: https://github.com/symbol/desktop-wallet/blob/3e3f46f184e4700e52fd4b5520b91dcdd6e3f510/src/views/modals/ModalTransactionCosignature/ModalTransactionCosignatureTs.ts#L263
The issue is related to https://github.com/symbol/desktop-wallet/issues/1849. When we call multisig/graph for cosigner not the entire tree is returned. We can use proposed fix here https://github.com/symbol/desktop-wallet/issues/1849 (additional call) to fetch entire tree.
Fixed in https://github.com/symbol/desktop-wallet/pull/1847
Released in 1.0.11