Harvesting: Move fee selector to pop-up

[cryptoBeliever]

Description:

Currently, on harvesting view, we have a "Fee" selector. Users confuse very often value selected there with a potential reward for a harvested fee and try to change it to "Fast".

Change proposition:

Because the "Fee" selector applies to the transaction we will send when "Stop harvesting", then maybe we can move the "Fee" selector on the transaction pop-up.

[postoronnii]

@cryptoBeliever Maybe it just makes sense to add a warning under the fee selector that the fee doesn't affect the Harvesting reward?

[cryptoBeliever]

@NikolaiB it will probably reduce questions but giving text don't change that UI is bad and very confusing for user.

[segfaultxavi]

There's already a warning under that input box :) How about we change the label Fee to Fee to pay for this transaction. There is plenty of room to the right since the dropdown is oversized given its actual content.

And I agree whatever we do we need to be consistent and do the same in all Fee selection dropdowns.

[cryptoBeliever]

@segfaultxavi user ​will don't know which one transaction ("Fee to pay for this transaction"). When the user opens this harvesting view mostly, he doesn't want to send any transaction (it's another case compared to the transfer transaction view), he activated harvesting, and that's all. This fee applies to transactions that will be sent when the user will click "Stop harvesting". So correct field name should be like "Fee to pay for the transaction if you click 'stop harvesting' button" :)

That's why I think removing the fee selector from there and moving it to a place when we are sure the user want send a transaction is a good idea. But of course, I'm open to other propositions.

[segfaultxavi]

Oh, I see. I agree, yes, the user doesn't know anything about "transactions" when he's trying to enable harvesting.

Moving the selector to a place where it is more clear that you are about to send a transaction looks like the right thing to do, yeah.