desktop-wallet
desktop-wallet copied to clipboard
symbol
Dashboard - For aggregate tx "From" is presented as initializing cosigner instead multisig account
Version: 1.0.3
Steps to reproduce:
- Create multi-sig account (in this example 2 of 2 multi-sig) and not related wallet W1.
M TDJZJWJCW7W7EZSOHPWL4BBCYBVUJEP7WN52KCA C1 TB2Z6E5VCEFQQN4DTZNYDPJYRFDSYCSQYYLPVXY C2 TASS5DO72MEOWHZZMTTIOPIVA5F7W4QZGYKRUNA
W1 TBYZ5FOQCJB4GRDUOFJWWPMQYQWHGRBLCVWV2KI
- Send multisig (aggregate) transaction from multisig M using cosigner C1 to wallet W1.
- Sign transaction using cosigner C2.
Result:
On dashboard you can see From as TB2Z6E5VCEFQQN4DTZNYDPJYRFDSYCSQYYLPVXY which is cosigner instead multisig account:
In details "From" is presented correctly:
Expected result: Present on dashboard correct "From" value.
If this is a limitation of REST API we should think of fixing it.
@cryptoBeliever I think this will need rest to be updated providing inner transaction Details as with the current version it forces wallet to make an extra call for each aggregate transaction in order to know the initiator of the transaction, which IMO will harm the performance.
Current working looks like that. Transactions are first loaded with wrong "From/To" and after some time (when wallet will read all aggregate transactions) address changes to correct one. Also, this change has a significant impact to performance. My suggestion would be to wait with releasing that when at least task : https://github.com/symbol/desktop-wallet/issues/1652 will be done.
@bassemmagdy @yilmazbahadir maybe we can cache information fetch for aggregate (currently only correct sender). This information will not change for specific hash. Currently, each time call to API is made. What do you think about that?
@cryptoBeliever I think it's a good idea to cache this data on the wallet side 👍
For the blinking issue on aggregate transactions, I think we can show "..." instead of the signerPublicKey until we get the aggregate data from the node.
