catapult-rest icon indicating copy to clipboard operation
catapult-rest copied to clipboard

Published 20 hours ago • verified publisher icon symbol

fix: removed decoded address

Open AnthonyLaw opened this issue 3 years ago • 2 comments

Current behavior

  • All the addresses in the REST response are in decoded format.
  • Example 98E0D138EAF2AC342C015FF0B631EC3622E8AFFA04BFCC56

What was the issue?

  • Decoded address format is not user-friendly. We have feedback from the community and discussion, change the address to encoded format.
  • Example TDQNCOHK6KWDILABL7YLMMPMGYRORL72AS74YVQ

What's the fix?

  • Convert addresses from decoded to encoded (base32) format.
  • updated unit test

AnthonyLaw avatar Jan 06 '22 09:01 AnthonyLaw

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 06 '22 09:01 sonarqubecloud[bot]

@AnthonyLaw Before merging, could you adjust the issue to follow this format seen here?

As a rule of thumb, you want to describe these three things:

  • What the current behaviour is.
  • Why this is an issue.
  • How you changed this behaviour.

I know it's a bit overkill for this change, but we want to get in a habit of doing this for each PR/issue.

0x6861746366574 avatar Jan 07 '22 03:01 0x6861746366574