catapult-rest icon indicating copy to clipboard operation
catapult-rest copied to clipboard

ArtifactId is not working in statements transaction filter.

Open AnthonyLaw opened this issue 4 years ago • 4 comments

namespace id : http://api-01.ap-southeast-1.0.10.0.x.symboldev.network:3000/namespaces/B29358EEA4333F88

http://api-01.ap-southeast-1.0.10.0.x.symboldev.network:3000/statements/transaction?pageSize=100&pageNumber=1&order=desc&artifactId=B29358EEA4333F88

AnthonyLaw avatar Nov 06 '20 15:11 AnthonyLaw

Hi @AnthonyLaw , where is artifactId coming from? it's not defined in the rest, sdks or open api.

Is this a feature request?

https://github.com/nemtech/symbol-openapi/blob/main/spec/core/transaction/routes/searchConfirmedTransactions.yml#L10

fboucquez avatar Nov 15 '20 10:11 fboucquez

Hi @fboucquez , it's from Receipt (plugins)

https://github.com/nemtech/symbol-openapi/blob/e41f9897fcab45fbc5ca580de247218f11b1e2e9/spec/plugins/receipt/routes/searchTransactionStatements.yml#L12

AnthonyLaw avatar Nov 15 '20 12:11 AnthonyLaw

I think a fix was implemented in this closed/unmerged pr https://github.com/nemtech/catapult-rest/pull/543 (unit tests never passed) @rg911

Another possible solution is to convert the artifactId for mosaicId and the user would need to resolve on the client side.

fboucquez avatar Feb 07 '21 14:02 fboucquez

I reopened the PR, but it probably needs some reworking. I would change it to P3 and client can use MosaicId for filtering.

rg911 avatar Feb 15 '21 10:02 rg911