catapult-rest
catapult-rest copied to clipboard
Monitoring changes to multisig account information
Given the following scenario:
- There are two regular accounts A and B, one multisg account M, cosigned by account A.
- Announce a multisigModify transaction that removes A as a cosigner of M and adds B as a cosigner of M.
In NIS 1, it is possible to listen for the confirmation of the transaction by listening to:
- Confirmed transactions of A
- Confirmed transactions of B
- Confirmed transactions of M
However in catapult, the way to check if the transaction has gone through is by listening to:
- confirmedAdded of A
- confirmedAdded of M
It seems that because it doesn't involve the signature of B, and the receiver is M, B never gets notified that it is added as a cosigner of another account.
Looking at the documentation in https://nemtech.github.io/api/websockets.html, I think account B should be notified of the transaction as it is "related to the address"
Posting this related issue there
if A has not announced its public key to the network
B adds A as a cosigner of C
A's partial/transaction
won't return the aggregate to sign until it has announced a transaction
Posting this related issue there
if A has not announced its public key to the network B adds A as a cosigner of C A's
partial/transaction
won't return the aggregate to sign until it has announced a transaction
is it possible you're referring to https://github.com/nemtech/catapult-rest/issues/173 ? or that issue always happens even if the accounts were already announced?
also what do you mean when you say partial/transaction
exactly?
#173 is fixed, isn't it? I've no issue with that anymore
partial/transaction: I'm talking about the partial/transaction endpoint, since it's about getting an aggregate transaction to cosign
On Wed, Dec 18, 2019, 15:50 Roger Hernandez [email protected] wrote:
Posting this related issue there
if A has not announced its public key to the network B adds A as a cosigner of C A's partial/transaction won't return the aggregate to sign until it has announced a transaction
is it possible you're referring to #173 https://github.com/nemtech/catapult-rest/issues/173 ? or that issue always happens even if the accounts were already announced?
also what do you mean when you say partial/transaction exactly?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nemtech/catapult-rest/issues/10?email_source=notifications&email_token=AIWPBP7YVYVYXLYVC7N2SKLQZHI5DA5CNFSM4GPMBNH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHFH2AA#issuecomment-566918400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWPBPYWSILXDLHFH3I5ZSDQZHI5DANCNFSM4GPMBNHQ .
ok, just wanted to make sure issues were not being duplicated
i suppose you mean the /transactions/partial
endpoint` ^^ @martinayora will take a look at this and give you a reply, because this may be a server limitation we recently encountered, otherwise, he will open a new issue and we will work on it (because this one is related to WS)
Right, /transaction/partial !
On Wed, Dec 18, 2019, 16:32 Roger Hernandez [email protected] wrote:
ok, just wanted to make sure issues were not being duplicated
i suppose you mean the /transactions/partial endpoint` ^^ @martinayora https://github.com/martinayora will take a look at this and give you a reply, because this may be a server limitation we recently encountered, otherwise, he will open a new issue and we will work on it (because this one is related to WS)
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nemtech/catapult-rest/issues/10?email_source=notifications&email_token=AIWPBP5AHOATJX6YBKQQ2SLQZHN3DA5CNFSM4GPMBNH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHFK34Q#issuecomment-566930930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWPBP5JBZT6ZCYEW6UOC3DQZHN3DANCNFSM4GPMBNHQ .
to clarify: there are two issues within this one, we will try to take a look "soon"
Notifications for the multisig account can be automatically subscribed from the SDK. The recent change (0.23.1) takes optional parameter for cosigners when subscribing to ws listener, and automatically subscribe the multisig account as well. Could this also be done via the rest to reduce the number of requests ?