symbl-twilio-video-react icon indicating copy to clipboard operation
symbl-twilio-video-react copied to clipboard

[Bug]: Null comparisons without type checking

Open Biki-das opened this issue 3 years ago • 2 comments

Contact Details

No response

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

i found piece of code doing null comparison without type safety,

this is what it looks like if (installingWorker == null) { return;} (contentType != null && contentType.indexOf('javascript') === -1)

Expected Behavior

adding type safety will be better if (installingWorker === null) { return; } (contentType !== null && contentType.indexOf('javascript') === -1)

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

What browsers are you seeing the problem on?

No response

Anything else?

No response

Biki-das avatar Oct 25 '21 07:10 Biki-das

@visharma-symbl could you review this issue and give me some feedback

Biki-das avatar Oct 25 '21 07:10 Biki-das

thanks @Akankshabhasin for assigning

Biki-das avatar Oct 25 '21 11:10 Biki-das