Mate Szalay-Beko
Mate Szalay-Beko
It looks the test class is actually fails now on Jenkins: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1883/testReport/
Looks OK, waiting for CI to finish
@eolivelli what do you think the suggested improvement on the Java client API? @anmolnar PTAL
thanks! I'll merge this and also test the patch on branch-3.6. (looks I remembered wrong, junit4 was introduced in 3.7 and not in 3.6 as I remembered)
I also changed the PR title to include the apache issue ID. Maybe this is what @maoling was referring by "link to".
also you accidentally committed this file: `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f`, please revert it. (this is a known irritating thing in ZooKeeper, some tests are changing this resource... as far as I remember maybe...
Thanks for working on this! :) Sorry, I was a bit overloaded with other tasks. I'll review on the weekend or Monday.
Thanks, it looks good to me now. But there is a unit test failing (`org.apache.zookeeper.test.QuorumTest.testSessionMoved`). Although I'm not sure if it is related to your change, or something different). I'll...
retest maven build
I tried it locally on my machine too. The same test runs for me on the master branch, but fails when I apply your patch. Please take a look.