Sylvestre Ledru
Sylvestre Ledru
many thanks for this terrific review :)
i know it is a draft but could you please add tests ? :) thanks
it should behave like GNU $ /usr/bin/shred --random-source=myfile a doesn't return anything
to reproduce the issue: bash util/build-gnu.sh && bash util/run-gnu-test.sh tests/shred/shred-exact
could you please replace your screenshot by copy and paste of the text? screenshots are terrible for accessibility and search thanks
this is probably an argument issue with clap
I guess you saw that the test is failing, right?
Before the GNU tests, the rust test suite is broken: https://github.com/uutils/coreutils/actions/runs/7458371831/job/20292245014?pr=5746 Example: ``` --- TRY 3 STDERR: coreutils::tests test_shred::test_shred_remove_wipe --- thread 'test_shred::test_shred_remove_wipe' panicked at 'Command was expected to succeed. stdout...
Reported also here: https://bugzilla.mozilla.org/show_bug.cgi?id=1828390
@nandhinianandj ping?