IDLua icon indicating copy to clipboard operation
IDLua copied to clipboard

Plugin sources don't correspond to the version that's published to the Marketplace

Open ForNeVeR opened this issue 4 years ago • 0 comments

While investigating issue #22, I've found some contradictions between version published to the Marketplace (1.0.127) and the sources in the repository.

The main difference seems to be that certain components are commented-out on GitHub: https://github.com/sylvanaar/IDLua/blob/ffc0589fca36b1837895cbf99f8ef3870ce1b685/src/main/resources/META-INF/plugin.xml#L88-L96 The same components are enabled in the plugin.xml of the published plugin version.

⚠Notably, disabling these components (i.e. using the version of plugin.xml from GitHub) lets the plugin to work in Rider. So maybe you really should publish a version without these components?

(namely, it's the com.sylvanaar.idea.Lua.LuaLoggerManager which causes a loading error in Rider; the reason for that ~~is unknown yet, though~~ is described in #27)

Another issue I've found is that build.gradle uses ideaVersion property: https://github.com/sylvanaar/IDLua/blob/ffc0589fca36b1837895cbf99f8ef3870ce1b685/build.gradle#L27

This property is never defined in the repository, so one has to guess what version they should substitute to build the plugin (and I never was able to generate the same artifact as the one published on the Marketplace from the current sources).

ForNeVeR avatar Jan 20 '21 11:01 ForNeVeR