react-prismazoom icon indicating copy to clipboard operation
react-prismazoom copied to clipboard

Published 20 hours ago • verified publisher icon sylvaindubus

Pan does not work with React 18

Open empawlo opened this issue 2 years ago • 4 comments

Hello all

just upgraded to React 18.1.0 and have noticed that the pan no longer works. Please test it yourself - there are also problems on mobile devices. I'll downgrade to React 17 until a solution was found. I am looking forward to it...

empawlo avatar May 05 '22 12:05 empawlo

Can confirm, the pan doesn't seem to work in [email protected] — will keep an eye out here, and downgrade in the meantime 😊

brianlovin avatar May 08 '22 05:05 brianlovin

Hi,

My bad, I think it was still using React 17 under the hood when I've tested it.

It should be fixed in 3.0.3, let me know if it's working back so I can close this. ;)

sylvaindubus avatar May 08 '22 09:05 sylvaindubus

Working for me @sylvaindubus — apologies for the slow reply here!

I can stub something out in the meantime, but a @types/react-prismazoom would be awesome for TypeScript users (maybe a lot of people with Next.js?). Anyways, I'm sure it's not a priority, but wanted to mention it 😊

Thank you!

brianlovin avatar May 23 '22 02:05 brianlovin

Glad to hear it's now working correctly!

Btw, I would love to transform all the codebase in Typescript, it's even at the top of the todo list (in the Contribution part of the readme), unfortunately it takes some time and I don't have enough of it for now. If you feel motivated, you are most welcome. 😉

sylvaindubus avatar May 24 '22 14:05 sylvaindubus