jpegview icon indicating copy to clipboard operation
jpegview copied to clipboard

Add copy file path

Open kropptrevor opened this issue 3 years ago • 1 comments

Implements #36

In the right click menu:

Copy to clipboard Ctrl+C Copy original size image Ctrl+X Copy file path Paste from clipboard Ctrl+V

I wasn't sure what the default key binding would be. Any suggestions?

kropptrevor avatar May 21 '22 02:05 kropptrevor

Interesting... I like this feature, and you've added it pretty cleanly

sylikc avatar May 26 '22 19:05 sylikc

Nice! I would go with some modification of C. E.g. Ctrl+Shift+C

Bobbsterman avatar Nov 02 '22 00:11 Bobbsterman

I've added a shortcut and an entry in the help screen. I did not provide translations, however.

kropptrevor avatar Nov 02 '22 20:11 kropptrevor

Nice. Lets hope @sylikc finds time to pull some of these enhancements!

I can provide a French translation: "copy image path to clipboard" = "copier l'emplacement de l'image"

Bobbsterman avatar Nov 02 '22 21:11 Bobbsterman

@Bobbsterman I'm merging this PR... the exact translation strings are right now are

"Copy file path of the image to clipboard" and "Copy file path"

I'll roll them in when you translate. Some of the translation stuff also needs to get cleaned up as per #105

sylikc avatar Jan 07 '23 21:01 sylikc

@kropptrevor thanks for the contribution. This will likely end up being a feature I use almost daily!

Certainly was helpful to review your code, where I forgot to put help in my "Open containing folder in Explorer" feature, and forgot to disable it for clipboard images. 65e7905

FYI: I fixed the Russian translation file getting mangled and also the popup menu bug a326463

sylikc avatar Jan 07 '23 21:01 sylikc

That's good to hear. I'm happy to have contributed.

kropptrevor avatar Jan 08 '23 00:01 kropptrevor