jpegview icon indicating copy to clipboard operation
jpegview copied to clipboard

Refactor animated image cache deletion

Open qbnu opened this issue 2 years ago • 4 comments

qbnu avatar Oct 08 '23 23:10 qbnu

Ha. You beat me to it. And your solution is done more elegantly than what I had in mind.

I'm pretty sure it was the delete jxl and stuff that caused the PSD block not to work, because those sections are subbed out. I'll put the ifdef in the right places when I try another XP build

sylikc avatar Oct 09 '23 02:10 sylikc

Do you want to undraft this one or is there more changes you're doing for cache fixes?

sylikc avatar Oct 16 '23 20:10 sylikc

@sylikc I haven't actually tested this, and I'll probably refactor more stuff later

qbnu avatar Oct 19 '23 01:10 qbnu

Ok, yeah I wanted to try to look at the "fallback detection" idea that I had. It touches the same code as the cache cleanup, so I can test this when I develop or just merge it if you've used it.

My idea is to add an option as to what other methods to try to fallback when an image isn't properly loaded. It would address a behavior that I reported to remind myself #246

sylikc avatar Nov 23 '23 08:11 sylikc