jpegview icon indicating copy to clipboard operation
jpegview copied to clipboard

Published 20 hours ago • verified publisher icon sylikc

Exif data loss after lossless transformations.

Open pelsta opened this issue 1 year ago • 5 comments

After lossless image transformations (left rotation, cropping, etc.), exif data are not saved to the file. This has been happening since version 1.2.45.0.

pelsta avatar Oct 07 '23 11:10 pelsta

hmm 🤔... i did a diff and nothing changed that would affect that in 1.2.45 vs 1.1.44 ...

https://github.com/sylikc/jpegview/compare/v1.1.44...v1.2.45

but I did a simple test with the old version and it definitely broke in 1.2.45

sylikc avatar Oct 07 '23 17:10 sylikc

I examined the code paths to get to the TurboJPEG call... nothing changed, and the library didn't change in 1.2.45 ... I'll have to look into it more deeply 🤦‍♂️

sylikc avatar Oct 07 '23 19:10 sylikc

@qbnu would you have any ideas what changed that could've broke this feature? I've been staring at it for a few hours and nothing stands out as to why it worked in 1.1.44 but not in 1.2.45

sylikc avatar Oct 07 '23 22:10 sylikc

@sylikc caused by https://github.com/sylikc/jpegview/commit/0104c93073395178514b9cfe59619bfb6eea3f3d.

It looks like there were a lot of API changes in TurboJPEG 2.1.91, so it's probably because of that.

qbnu avatar Oct 08 '23 21:10 qbnu

Time to move to libjpeg-turbo v.3.0.0?

Hrxn avatar Oct 09 '23 03:10 Hrxn