Sylvain comments

Results 27 comments of


                                            Sylvain

[Lock] Better key naming when possible

Thanks @stof I changed the PR * I use the plain string * \>= 64 => I use the hash This prevents a 64-character plain string from colliding with a...

[Lock] Better key naming when possible

Thanks @OskarStark for spotting the typos 👍

[Test] Client reboots between requests

> When you disable the reboot, the isolation by-test is still working? @soyuka Yes it is because the Alice bundle rolls back the MySQL transaction when a call to `ensureKernelShutdown()`...

[Test] Client reboots between requests

@soyuka Because I am not aware of all usages of the Symfony's KernelBrowser: it may have use cases where rebooting after each request is legitimate. Changing it would break these...

ModuleNotFoundError: No module named 'audioread'

It looks like this hash is used since day 1 https://github.com/symfony/lock/commit/a9997e2a151cde49b545d8aa71de305e848dd347#diff-f1fb142b78edb31aa4419deda4cc056f571e41507c7e1edcd756657c5524b0eaR215

ModuleNotFoundError: No module named 'audioread'

@nicolas-grekas Would you accept a PR to change that?

ModuleNotFoundError: No module named 'audioread'

hello @xabbuh, what do you think of my suggestion?