sygma-sdk
sygma-sdk copied to clipboard
feat(evm)!: Added support for creating cross chain non fungible asset transfer transactions
feat(evm)!: Added support for creating cross chain non fungible asset transfer transactions
Description
- Added two BaseClasses between ERC20, ERC721 and Generic transfer classes as there was room for reasonable abstraction among them.
- Renamed main files with more descriptive names
- Fixed breaking tests
Breaking Changes:
-
createEvmFungibleAssetTransfer
renamed tocreateFungibleAssetTransfer
as it doesn't provide unnecessary context. -
setAmount
renamed tosetTransferAmount
to match with getter name inFungibleAssetTransfer
-
amount
withinFungibleAssetTransfer
is nowprotected
and its getter is calledtransferAmount
-
destinationAddress
address has been renamed torecipientAddress
in fungible asset transfer class
Closes:$ #345
How Has This Been Tested? Testing details.
- TODO: unit tests for
NonFungibleAssetTransfer
class. - TODO: units tests for
createNonFungibleAssetTransfer
function.
Types of changes
- [X] New feature (non-breaking change which adds functionality)
- [X] Breaking change (fix or feature that would cause existing functionality to change)
- [X] Documentation
Checklist:
- [X] I have commented my code, particularly in hard-to-understand areas.
- [X] I have ensured that all acceptance criteria (or expected behavior) from issue are met
- [x] I have added tests to cover my changes.
- [x] I have ensured that all the checks are passing and green, I've signed the CLA bot