sygma-sdk icon indicating copy to clipboard operation
sygma-sdk copied to clipboard

feat(evm)!: Added support for creating cross chain non fungible asset transfer transactions

Open saadahmsiddiqui opened this issue 6 months ago • 0 comments

feat(evm)!: Added support for creating cross chain non fungible asset transfer transactions

Description

  • Added two BaseClasses between ERC20, ERC721 and Generic transfer classes as there was room for reasonable abstraction among them.
  • Renamed main files with more descriptive names
  • Fixed breaking tests

Breaking Changes:

  • createEvmFungibleAssetTransfer renamed to createFungibleAssetTransfer as it doesn't provide unnecessary context.
  • setAmount renamed to setTransferAmount to match with getter name in FungibleAssetTransfer
  • amount within FungibleAssetTransfer is now protected and its getter is called transferAmount
  • destinationAddress address has been renamed to recipientAddress in fungible asset transfer class

Closes:$ #345

How Has This Been Tested? Testing details.

  • TODO: unit tests for NonFungibleAssetTransfer class.
  • TODO: units tests for createNonFungibleAssetTransfer function.

Types of changes

  • [X] New feature (non-breaking change which adds functionality)
  • [X] Breaking change (fix or feature that would cause existing functionality to change)
  • [X] Documentation

Checklist:

  • [X] I have commented my code, particularly in hard-to-understand areas.
  • [X] I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • [x] I have added tests to cover my changes.
  • [x] I have ensured that all the checks are passing and green, I've signed the CLA bot

saadahmsiddiqui avatar Aug 15 '24 14:08 saadahmsiddiqui