sycamore icon indicating copy to clipboard operation
sycamore copied to clipboard

Book (website) routing not properly updating

Open lukechu10 opened this issue 1 year ago • 8 comments

Describe the bug When navigating to a new page in the Book, there is sometimes what seems to be a race-condition which causes the following visual bug to happen: image Relevant Discord discussion

To Reproduce Steps to reproduce the behavior:

  1. Go to https://sycamore-rs.netlify.app/docs/getting_started/hello_world
  2. Click on another page from the sidebar, e.g. "Hello World!"
  3. (Maybe) observe the visual bug.

Environment

  • Sycamore: 0.9.0-beta.2, current master (16acf8e)
  • Browser: Edge 119

lukechu10 avatar Dec 02 '23 20:12 lukechu10

It seems that the book works normal now. Edge Version 121.0.2277.4 (Official build) stable app, beta channel (64-bit)

Saplyn avatar Jan 03 '24 06:01 Saplyn

The annoying part is that I'm only able to reproduce this sometimes and always when I think I've solved the issue. So I'll leave this open for now until I'm more certain that it's fixed.

lukechu10 avatar Jan 03 '24 20:01 lukechu10

I can consistently reproduce on Chromium: 122.0.6261.69:

  1. navigate to https://sycamore-rs.netlify.app/ (navigating directly to the home page or reloading on the homepage if I come from another page)
  2. press either
  • "Get Started" button in the middle of the page
  • "Book" menu at the top
  1. Navigating within the docs with the links now creates rendering issue, as well as scrolling the left-side menu
  2. reloading the page while in the docs fixes the rendering

Left side menu scrolling issue: Screenshot 2024-02-28 at 10 02 55 AM

steven89 avatar Feb 28 '24 09:02 steven89

Also once in the docs (after a reload) clicking on a latest version link ("For up-to-date documentation, see the latest version (v0.8).") restarts the rendering issue, again reloading the page afterwards fixes it.

steven89 avatar Feb 28 '24 09:02 steven89

I can reproduce on Firefox 123.0 for MacOS.

When I clicked 'Get Started', the <div class="flex w-full"> tag was created twice. The website updates only the second <div class="flex w-full">tag and leaves the others unchanged after I clicked a link on the navigation. In addition to, right-side menu for 'Getting Started' was overwritten by one for 'Basics'

https://github.com/sycamore-rs/sycamore/assets/29543842/88296866-c9f8-4847-8a38-6e930eb5729c

Hmikihiro avatar Mar 06 '24 07:03 Hmikihiro

I can reproduce on Firefox 123.0 for MacOS.

When I clicked 'Get Started', the <div class="flex w-full"> tag was created twice. The website updates only the second <div class="flex w-full">tag and leaves the others unchanged after I clicked a link on the navigation. In addition to, right-side menu for 'Getting Started' was overwritten by one fo

Ah thanks for digging into this. Apologies I've just been really busy with other things lately so haven't even gotten a chance to look at this. But this does make it clearer what went wrong!

lukechu10 avatar Mar 06 '24 22:03 lukechu10

Ok another test case, starting on one of the doc pages and clicking on the logo in the top-left doesn't seem to work either.

lukechu10 avatar Mar 07 '24 23:03 lukechu10

Clicking on the "News" also works like clicking on the logo.

https://github.com/sycamore-rs/sycamore/assets/29543842/7f004313-798d-4491-803a-bea0eda424e3

Hmikihiro avatar Mar 08 '24 08:03 Hmikihiro

Since we now have a new docsite, this issue is no longer relevant.

lukechu10 avatar Oct 20 '24 09:10 lukechu10