Maxim Syabro

Results 50 comments of Maxim Syabro

@multipliedtwice why did you create a PR to the author's repo then? 🙂

> just in case someone doesn't want to do the same job all over again totally makes sense, thank you

Same here. I don't get concept of "apps" in "config". Is it `django-apps` like approach where `app` is a submodule or here `app` is more like a project?

@DamonOehlman thanks for the reply! I dont' have access to posthog's scripts. So they do the detection by using `detect-browser`. I guess a lot of analytics scripts do the same....

@DamonOehlman from my perspective it's a browser, not a platform. Technically it's chromium inside so if it was my call I would go with adding a new browser. But up...

https://github.com/umami-software/umami/blob/master/package.json#L87C6-L87C20 https://github.com/umami-software/umami/blob/master/src/lib/detect.ts#L134 For the record: Umami uses it as well ``` const browser = browserName(userAgent); ```

@DamonOehlman I think adding electron detection as a separate browser it wouldn't affect 99.99% users since nobody uses it on purpose. But in this case tracking it will be great...

@SilentGlasses not sure. My `.zsh_hisrtory` contains only timestamps and commands. But warp show me the folder where it was run plus branch.

@dannyneira what do you say about `warp.sqlite`'s `commands` table? Looks like it stores all commands and Warp's history grouping uses at least `command` + `pwd` columns instead of just `command`