yazi icon indicating copy to clipboard operation
yazi copied to clipboard

Failed to stop searching after `yazi` is quitted

Open NeumoNeumo opened this issue 1 year ago • 2 comments

What system are you running Yazi on?

Linux X11

What terminal are you running Yazi in?

kitty 0.32.2

Yazi version

yazi 0.2.3 (42cbedb 2024-02-25)

Did you try the latest main branch to see if the problem got fixed?

Tried, but the problem still

Describe the bug

When searching usingrg or fd in a large directory, it is OK to take a long time. However, when I want to cancel the process by just quitting yazi. The processes of rg or fd are still running in the background.

Open yazi: image

Searching for some file in yazi: image

fd is still running without the presence of yazi: image image (The server is using NFS so the REAL disk IO is actually displayed in the Network instead of Disk IO in the above screenshot of htop)

Expected Behavior

After quitting yazi, all processes related to it should be killed.

To Reproduce

  1. Find a large directory, for example, the root.
  2. Open yazi and search for some file, like "gagaga".
  3. Before the yazi completes the search task, quit it.
  4. You would find the searching process is still running in the background.

Configuration

no config

Anything else?

No response

NeumoNeumo avatar Feb 25 '24 07:02 NeumoNeumo

How did you exit Yazi, by using q to quit it normally, or by forcefully ending it with something like kill yazi?

sxyazi avatar Feb 25 '24 15:02 sxyazi

How did you exit Yazi, by using q to quit it normally, or by forcefully ending it with something like kill yazi?

I exited Yazi by q.

NeumoNeumo avatar Feb 26 '24 00:02 NeumoNeumo

Hi, I made a PR trying to fix this issue https://github.com/sxyazi/yazi/pull/812, let me know if it works for you

sxyazi avatar Mar 13 '24 15:03 sxyazi

Hi, I made a PR trying to fix this issue #812, let me know if it works for you

Thank you. It works! :smile:

NeumoNeumo avatar Mar 13 '24 16:03 NeumoNeumo

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Apr 13 '24 03:04 github-actions[bot]