Stewart X Addison
Stewart X Addison
That would be my assumption yes. The previous issues and PRs suggest this was resolved, so we'd just need to understand what happened and potentially reimplement a fix for it.
Thanks @rvagg - I've worked on reproducible build environments for another project, and the Node.js build is close other than those two issues above, so it should just require a...
Definitely still work to do and I still plan to look at it.
Just tried four consecutive builds with the latest code and the `debug-support.cc` came out the same each time. There have been [four V8 version bumps](https://github.com/nodejs/node/commits/main/deps/v8/tools/gen-postmortem-metadata.py) since I last tested (10.1.124.6...
Looks like the break was between these two commits, so https://github.com/nodejs/node/commit/1faf6f459f likely made it non-reproducible again. ``` * 1faf6f459f 2019-04-21 | src: snapshot Environment upon instantiation (HEAD, refs/bisect/bad) [Joyee Cheung]...
@joyeecheung Would you be able to assist with the reproducibility of the snapshots now? I'm not sure who else might have good knowledge of the snapshot support in Node so...
Sounds like good progress - thanks @joyeecheung!
I've put https://ci.nodejs.org/job/reproducibility-test/ in place to test how reproducible the builds are on Linux/aarch64 - it will run weekly: 1. It will compare two builds with `--without-node-snapshot` and fail the...
> Thanks, I think when [nodejs/node#48851](https://github.com/nodejs/node/pull/48851) lands, we could also add another flag to display the `node_snapshot.cc` in a more human readable way, then the CI can just diff the...
Job updated to it will diff the `.cc` file and store the output e.g. https://ci.nodejs.org/job/reproducibility-test/lastSuccessfulBuild/artifact/snapshot.cc-diff.log