Stewart X Addison

Results 1807 comments of Stewart X Addison

My current initial approach has been to install a suitable capstone as part of the machine setup process (within our ansible scripts) and then invoke the appropriate options during the...

After a couple of discussions today I am now leaning more towards an option 2.5 (Somewhere between 2 and 3) of pulling from pre-built binaries on stored in the `userContent`...

> Be aware that Capstone can be built in multiple ways. By default, it builds for all architectures. This is not what we want. Yep the [draft PR I had](https://github.com/adoptium/infrastructure/pull/3119)...

> An alternative would be to link hsdis _statically_ against libcapstone. I'm thinking we go for an initial approach of doing it dynamically against a suitable capstone and then subsequently...

PRs to achieve this: - https://github.com/adoptium/infrastructure/pull/3119 - https://github.com/adoptium/temurin-build/pull/3414

Test builds of jdk-21+35 with this support added have been built for [x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21/job/jdk21-linux-x64-temurin/123/artifact/workspace/target/) and [aarch64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21/job/jdk21-linux-aarch64-temurin/100/artifact/workspace/target) (although they will not be retained there indefinitely). As a one-off for people to experiment...

The PMC decided today to not include it in the 20.0.1 October deliverable and to subsequently evaluate whether this was useful in a non-development build of the JDK. As an...

> > The PMC decided today to not include it in the 20.0.1 October deliverable and to subsequently evaluate whether this was useful in a non-development build of the JDK....

_(Copying this in from something I posted in another email thread)_ It looks like we might have some issues relating to capstone versioning. A build of the hsdis module done...

Further analysis has determined that this is is related to the use of `-qvisibility=hidden` and a proposal to resolve this is in https://github.com/openjdk/jdk21u/pull/459/files