swoole-src icon indicating copy to clipboard operation
swoole-src copied to clipboard

Fix hook socket in non-coroutine

Open Yurunsoft opened this issue 2 years ago • 2 comments

Other functions that are hooked are compatible in the non-coroutine

https://github.com/swoole/swoole-src/blob/3965e3a0640c693d70233142120a4e0cc387385a/include/swoole_socket_hook.h

Yurunsoft avatar Jul 28 '22 07:07 Yurunsoft

Codecov Report

Merging #4774 (277ae1e) into 4.8.x (3a07db9) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            4.8.x    #4774      +/-   ##
==========================================
- Coverage   52.64%   52.62%   -0.03%     
==========================================
  Files          73       73              
  Lines       14940    14944       +4     
==========================================
- Hits         7865     7864       -1     
- Misses       7075     7080       +5     
Impacted Files Coverage Δ
src/coroutine/hook.cc 67.24% <100.00%> (+0.46%) :arrow_up:
src/os/msg_queue.cc 57.62% <0.00%> (-3.39%) :arrow_down:
src/protocol/base.cc 62.65% <0.00%> (-1.81%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 28 '22 07:07 codecov[bot]

Tests needed

twose avatar Jul 28 '22 08:07 twose