diddy icon indicating copy to clipboard operation
diddy copied to clipboard

diddyreader.monkey: set graphicsPath on LoadMap

Open nobuyukinyuu opened this issue 10 years ago • 3 comments

Note: _StripDir doesn't appear to be used, but ExtractDir is used here. To avoid brl.filepath import, I've thrown the function into this file. However, I don't see an issue with using brl.filepath in general. Feel free to refactor/clean this up as you see fit.

Other notes: I couldn't find anything that actually set graphicsPath anywhere in the original code. What?

nobuyukinyuu avatar Aug 26 '15 18:08 nobuyukinyuu

_StripDir was used before your change in the ReadImage method of the diddyreader.monkey (and in the skn3reader.monkey):

If node.HasAttribute(ATTR_IMAGE_SOURCE) Then rv.source = graphicsPath + _StripDir(node.GetAttribute(ATTR_IMAGE_SOURCE))

Yeah I'm not sure what if anything sets graphicsPath....

therevills avatar Aug 26 '15 22:08 therevills

if that is the case, then patch-3 should fix everything.

nobuyukinyuu avatar Aug 26 '15 22:08 nobuyukinyuu

We'll have to test later... also just a small thing this code doesnt comply with Diddy's coding standards. Diddy uses "End" not "End If" (or it should in 99% of the code :))

therevills avatar Aug 26 '15 22:08 therevills