swizzin icon indicating copy to clipboard operation
swizzin copied to clipboard

fix(qbittorrent): Improve webclient performance

Open brettpetch opened this issue 3 years ago • 11 comments

improve performance on large queues. no negative impacts.

Description

Modify sizes & timeouts to improve performance with large amounts of torrents.

Fixes issues:

  • Un-tracked issue... Large torrent queues become unresponsive in queues ~5500 torrents.

Proposed Changes:

  • Modified nginx conf for qbit, queues above 5500 torrents would have issues with responsiveness.

Change Categories

  • Bug fix

Checklist

  • [x] Docs have been made OR are not necessary
    • PR link:
  • [x] Changes to panel have been made OR are not necessary
    • PR link:
  • [x] Code is formatted (See more)
  • [x] Shellcheck isn't screaming (See more)
  • [x] Prints to terminal are handled (See more)
  • [x] I have commented my code, particularly in hard-to-understand areas

Test scenarios

Architectures

amd64 armhf arm64 Unspecified
Focal
Bionic
Buster
Stretch
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

None afaik

❌❌ Currently failing

None afaik

brettpetch avatar Jan 31 '21 09:01 brettpetch

Did you actually test this out on all those arches and OSs? :p

flying-sausages avatar Feb 01 '21 01:02 flying-sausages

Did you actually test this out on all those arches and OSs? :p

mb. Testing was split between stretch and ubuntu focal for ARM devices. service nginx configtest passed on all counts.

brettpetch avatar Feb 01 '21 01:02 brettpetch

Should be set now. Testing still required-- issues could exist, but internet has been unstable. Next possible test will on monday morning EST.

brettpetch avatar Feb 20 '21 01:02 brettpetch

tests pls

flying-sausages avatar Apr 27 '21 18:04 flying-sausages

testing now.

brettpetch avatar Apr 27 '21 19:04 brettpetch

testing now.

how'd it go? 😛

flying-sausages avatar Jul 12 '21 22:07 flying-sausages

hey, just looked back into this. The only part that really mattered from it was the following:

    client_max_body_size 24M;
    client_body_buffer_size 128k;    
    fastcgi_buffers 8 16k;
    fastcgi_buffer_size 32k;

brettpetch avatar Jul 15 '21 19:07 brettpetch

Are we ok with forcing the updater to overwrite the whole qbit config? I am personally fine with that

flying-sausages avatar Jul 15 '21 20:07 flying-sausages

I am fine with that as well. It’s unlikely people mod it too much.

/b

On Jul 15, 2021, at 4:49 PM, flying-sausages @.***> wrote:

 Are we ok with forcing the updater to overwrite the whole qbit config? I am personally fine with that

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brettpetch avatar Jul 15 '21 21:07 brettpetch

Are we ok with forcing the updater to overwrite the whole qbit config? I am personally fine with that

@flying-sausages here's my current thoughts on this, we can ship it, but what if we used sed to change only the affected lines in an updater?

/b

brettpetch avatar Aug 25 '21 18:08 brettpetch

Any more progress on this ?

luzpaz avatar Jun 14 '23 15:06 luzpaz