swittk

Results 45 comments of swittk

Sure, will open a PR for that. Meanwhile I did a hypothesis-testing branch to prove that the current issue is due to dependency cycles. https://github.com/swittk/Parse-SDK-JS/tree/uglyrequires This branch passes all tests,...

> @swittk Thank you for picking this up! I added a few comments and nits > > For the issue you are having with the unit tests try adding the...

Jest tests appear to be fixed. But seems like the Integration test still fails due to the dependency cycles though.

Just asking.. I'm trying the refactors, but I'm encountering errors in the tests, since they expect to mock ParseObject (e.g. `unsavedChildren-test.js`, but with unsavedChildren defined together in the same file...

Thanks. I've added you as a collaborator to my fork.

Would using registration of currently heavily reused classes (ParseQuery, ParseACL) into `CoreManager` be considered as an option? (or a similar object/registry that allows for dynamic registration of classes/objects). Since most...

@dplewis I've made another branch with my proposed changes by using CoreManager as a central registry for classes that are reused. Most of the circular dependencies are fixed (and the...

Hi. Thanks for reviewing! (and sorry for the late reply) Just wondering; do you have any suggestions on how I might import that function (the one that converts UTF-8 to...