Pascal Birchler

Results 727 comments of Pascal Birchler

> Please do let me know if you feel that grouping/tagging/categorization is something that will be picked up Off the top of my head I'd say it's unlikely or not...

No idea why those e2e tests fail... It's only the ones involving other users. 🙃 🤷

All e2e tests involving non-admin users are failing. I'm a bit at loss as why this happens. Looking at the artifacts, they seem to be stuck at the very beginning...

> We should also prerender the stories when a stories block is added to the front end. I was wondering what hook I could use for the same, to attach...

Are speculation rules added on that page and Is the browser perhaps preloading the link? Maybe that causes some issues? The error says `response` is null, which is suspicious. Could...

> This test failed on the main branch too. Where do you see this fail on main? Looks all green to me here: https://github.com/GoogleForCreators/web-stories-wp/actions/workflows/tests-e2e.yml?query=branch%3Amain > Also the strange part is...

Okay, strange. I can try to reproduce this later this week. But let's not have this block us. In the meantime, do you perhaps have any thoughts on https://github.com/GoogleForCreators/web-stories-wp/pull/13616#issuecomment-2039831290 and...

I don't like that, because > the `Renderer` classes are not singletons, and ideally we would only add the filter once. The Web Stories block can be added dozens of...

So I think we can actually simplify this a lot address this issue. We don't actually need to know whether a stories block is on the page or not. We...

> Also, were you able to find out what's wrong with the failing tests? Interestingly it seems to pass now with the new version!