Pascal Birchler

Results 727 comments of Pascal Birchler

I don't understand the test failures, they look unrelated 🤔

Ah, when I try locally I get this: ``` $ WP_VERSION=trunk composer behat features/taxonomy.feature:7 > run-behat-tests 'features/taxonomy.feature:7' ----- --- Failed hooks: BeforeSuite # WP_CLI\Tests\Context\FeatureContext::prepare() $ wp cli info Error: Callable...

As just discussed on the Zoom call, it's because of https://github.com/wp-cli/wp-cli/pull/5928 We'll fix this separately.

https://github.com/wp-cli/wp-cli/pull/5928 has been reverted in the meantime

This makes sense to me 👍 Every once in awhile I install GlotPress again and get 404s because I forget the slashes.

> * Pass a new optional GitHub access token as a flag on the command. I'd use an environment variable instead, e.g. `getenv( 'GITHUB_TOKEN' )`

Please let us know if you need help with writing those tests. Would definitely be a nice enhancement.

I know it's been a while, but is this still an issue? Seems like it can't hurt to add an `is_array()` check there or so.