Pascal Birchler
Pascal Birchler
Can we add an `is_stream()` helper function to this? Then we can fix #5008 by leveraging this new class in the `normalize_path()` utility function.
Since you mentioned Site Kit by Google, you might also want to check out how we've done the prefixing in another Google plugin here: https://github.com/google/web-stories-wp/.
Feel free to provide feedback on #12382 if you'd like. This should not be blocking anything else though. Other packages can be migrated even without the `output` package being fully...
FWIW this ticket is not the blocking factor. There are three other ones currently blocking it.
Relevant code section: https://github.com/wp-cli/wp-cli/blob/28803dffcb9e041764aed6dd712346ca243cf0e8/php/WP_CLI/Runner.php#L474-L680 We'd need to dump the output from the server
Not sure we want to actually have a hardcoded date in there... I imagine next August we'll release a new version of WP-CLI that officially drops support. Then we can...
This command uses an external library for scanning PHP files and extracting strings from them, see https://github.com/php-gettext/Gettext. Such support would need to be added there first if not already present....
@gregberge so is this essentially a wontfix?
No need for assignements, just start working on it whenever you are interested. Can be during hack day but also before or after.
@ernilambar I just merged https://github.com/wp-cli/wp-cli/pull/5926 now To make the PR work now, update `composer.json` here to require `"wp-cli/wp-cli": "^2.11"`