Pascal Birchler

Results 727 comments of Pascal Birchler

Got it! OK, we're on the same page then.

The reason _why_ that happens is pretty clear I think: we add new uploading items to the library even before we do the cropping. Because of that the poster is...

Cropping with canvas is very easily possible, we don't need to use FFmpeg. It would be a one line change here: https://github.com/GoogleForCreators/web-stories-wp/blob/2c06dea77e044465aae90170a6104e2b2bbe2ba2/packages/media/src/getImageFromVideo.ts#L41 Not sure yet what to do about the...

The new recommended approach in v17.1.0 is to use `ElementHandle.frame()` directly, see https://github.com/puppeteer/puppeteer/pull/8875. It should be released soon.

Duplicate of #336 Please try `wp cli update --nightly`

From #4: > ...if only there was a way to fire up that js to automatically **start** the search immediately after the speech recognition realizes that the talking has stopped...

The text could be truncated using CSS, e.g. like this: ``` css .notification { width: 250px; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; } ``` The full text could be shown...

@johnbillion How well is this supposed to work yet? I am getting lots of "Filter callback return statement is missing" false positives. Example: https://github.com/GoogleForCreators/web-stories-wp/blob/c3b5eec59b0bb79dc096260f5c9614cffc3b3778/includes/Admin/Admin.php#L75C45-L78 The top three lines are getting...

https://github.com/buzz/mediainfo.js works well for this

Would you accept PRs against v4 to fix this?