Pascal Birchler

Results 727 comments of Pascal Birchler

Related: #12211 For background audio it's unfortunately not that straightforward to implement

I know, it‘s why it‘s still a draft

@barklund Looks like I broke `rich-text` tests here. Could you perhaps take a look? 😅 Not seeing the forest for the trees right now.

Something to fix in PHP-CSS-Parser: ``` PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /tmp/wordpress/src/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/src/Parsing/ParserState.php on line 129 PHP Deprecated: Using ${var} in strings is deprecated,...

> There's currently an error for PHP 7.4 with coverage. Yeah I saw it too and it's pretty confusing. Somehow the test never finishes, so there's no coverage file being...

@westonruter I found the issue 🥳 🎉 The culprit was the `test_handle_single_url_page_bulk_and_inline_actions` test covering `\AMP_Validation_Error_Taxonomy::handle_single_url_page_bulk_and_inline_actions()`. That method calls `wp_safe_redirect` and `exit()`, causing the tests to silently halt. I update the...

Slight correction, there are two more tests failing on trunk. They are unrelated to the changes here though. ``` 1) AMP_Style_Sanitizer_Test::test_prioritized_stylesheets with data set "admin_bar_included" (Closure Object (...), Closure Object...

> This bug was just fixed in Gutenberg yesterday: [WordPress/gutenberg#44829](https://github.com/WordPress/gutenberg/pull/44829) > So this will get resorted once the next GB version is released. FYI, while GB 14.4 was released _today_,...

> Unit test (with coverage): PHP 7.4, WP latest This required status check needs to be removed/changed, since now the coverage is done with PHP 8.0 instead.

I don‘t see an issue with merging this already, but up to you