design-system icon indicating copy to clipboard operation
design-system copied to clipboard

feat(styles): add custom theme for primeng

Open alizedebray opened this issue 1 year ago • 7 comments

alizedebray avatar Feb 22 '24 10:02 alizedebray

🦋 Changeset detected

Latest commit: e907059705b0570fecc197c86c0673bab78c1162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-styles-primeng-workspace Major
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 22 '24 10:02 changeset-bot[bot]

Preview environment ready: https://preview-2718--swisspost-web-frontend.netlify.app Preview environment ready: https://preview-2718--swisspost-design-system-next.netlify.app

swisspost-bot avatar Feb 22 '24 10:02 swisspost-bot

Quality Gate Failed Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

alizedebray avatar Feb 27 '24 17:02 alizedebray

Quality Gate Failed Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0) See analysis details on SonarCloud idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.

imagoiq avatar Feb 28 '24 08:02 imagoiq

Quality Gate Failed Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0) See analysis details on SonarCloud idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis? The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.

I marked the icon errors as false positive in Sonar and fixed the other issues.

alizedebray avatar Mar 05 '24 14:03 alizedebray

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Apr 29 '24 16:04 sonarqubecloud[bot]

Related Previews

  • https://preview-2718--swisspost-web-frontend.netlify.app
  • https://preview-2718--swisspost-design-system-next.netlify.app

swisspost-bot avatar Jun 20 '24 06:06 swisspost-bot