open-service-broker
open-service-broker copied to clipboard
Retryable in `OpsManagerFacade` probably does not work
Problem
OpsManagerFacade
is using Springs @Retryable
for one of its methods. In a recent change, the constructor of the MongoDbEnterpriseServiceProvider
was changed to instantiate the OpsManagerFacade by calling new OpsManagerFacade()
rather than using Springs autowiring. With that the @Retryable
annotation is no longer recognized, and the method is therefore not retried anymore in case of failures. Making things worse, there's no test verifying the retries for this method.
Requirements
- [ ] Verification of retries for the method
Proposal
- Add tests for OpsManagerFacade, specifically testing the
@Retryable
. Ideally done with WireMock. - Fix instantiation of the OpsManagerFacade in MongoDbEnterpriseServiceProvider.
Alternative
- Drop using
@Retryable
and implement another mechanism to retry the failed action.