cleanerversion
cleanerversion copied to clipboard
swisscom
Support for MySQL and Django 1.10
Hi,
Is there any appetite to support MySQL and Django 1.10? It looks like a very useful project, however the common combination of MySQL and the latest major Django version is not supported.
Thanks!
Hi @mikeengland, thanks for your interest. Let me elaborate a bit on Django version support: From Django 1.8 (LTS) to Django 1.9 there were major changes in the ORM. So, we're adapting code to have CleanerVersion run on Django 1.9. From what I saw, there are not that many changes in between 1.9 and 1.10, which would mean, that once we have support for 1.9, 1.10 would be an easy one. See PR #127 for the current state of work. Regarding support for MySQL/MariaDB, I think it is simply a matter of adding MariaDB to the list of tested environments (i.e. extending the TravisCI and TOX configs). Since SQLite is supported and we're not using any SQLite specific functions, MariaDB should work as well. Feel free to open a PR if you have any changes to contribute.
Thanks for the quick response @maennel. I saw the issue https://github.com/swisscom/cleanerversion/issues/105 where someone was complaining about tests failing. I'll keep an eye on the 1.9 progress, thanks!
I'll re-open this issue to make the desire for MySQL/Maria and Django 1.10 explicit.
@mikeengland while adding tests for MySQL/MariaDB, I stumbled upon an issue regarding timestamp precision with earlier versions of MySQL/MariaDB. So, please make sure you have the maximum precision (which is "6" positions after the comma) enabled for all DateTime fields on all Versionable models (version_birth_date, version_start_date, and version_end_date).
Otherwise, you may run into issues (for example quite a number of tests does not pass with "0" precision, i.e. all timestamps rounded to the next full second).
See this link for more info: https://docs.djangoproject.com/en/1.8/ref/databases/#fractional-seconds-support-for-time-and-datetime-fields