ngx-graph icon indicating copy to clipboard operation
ngx-graph copied to clipboard

chore: update d3 dependencies

Open Kr0san89 opened this issue 1 year ago • 13 comments

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) https://github.com/swimlane/ngx-graph/issues/500 https://github.com/swimlane/ngx-graph/issues/496 https://github.com/swimlane/ngx-graph/issues/495

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • [x] Yes
  • [ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... no IE, min node v12, maybe other

Other information: Hard to test would recommend publishing it as some unstable version, so that people can try it

Kr0san89 avatar Jul 05 '23 20:07 Kr0san89

@steveblue can you help ?

krishna217 avatar Jul 10 '23 06:07 krishna217

@marjan-georgiev can you have a check?

Kr0san89 avatar Jul 17 '23 11:07 Kr0san89

@jogaj @marjan-georgiev @steveblue can anybody check the PR. I think some people are needing it

Kr0san89 avatar Sep 05 '23 10:09 Kr0san89

Any status update on this, we're upgrading our Angular version and this is the only thing causing us to use legacy peer deps. And legacy peer deps creates a completely different package-lock.json. It seems a shame this PR has been open for ~3 months with no status updates.

Using 3.0 gives us this error

vendor.d5a14547d33d9b07.js:40 ERROR TypeError: Xu(...).select(...).attr(...).transition is not a function
    at vendor.d5a14547d33d9b07.js:98:1329288
    at Array.map (<anonymous>)
    at I5.map (vendor.d5a14547d33d9b07.js:40:100069)
    at y.redrawLines (vendor.d5a14547d33d9b07.js:98:1329152)
    at vendor.d5a14547d33d9b07.js:98:1326675
    at R.<computed> (polyfills.2d9350f0dc248b2e.js:18:28043)
    at P.invokeTask (polyfills.2d9350f0dc248b2e.js:18:7082)
    at Object.onInvokeTask (vendor.d5a14547d33d9b07.js:40:49942)
    at P.invokeTask (polyfills.2d9350f0dc248b2e.js:18:7003)
    at E.runTask (polyfills.2d9350f0dc248b2e.js:18:2444)

Pointing at this section of code. image

You can even see the issue using npm list d3-selection └─┬ @swimlane/[email protected] ├── [email protected] ├─┬ [email protected] │ └── [email protected] └─┬ [email protected] └─┬ [email protected] └── [email protected]

labeled avatar Oct 10 '23 13:10 labeled

Is there any update for this PR? It would be nice to be merged.

lazaro3487 avatar Dec 20 '23 11:12 lazaro3487

if you need it for security reasons you can try this package: https://www.npmjs.com/package/@kr0san89/ngx-graph/v/9.0.0-next-1

Kr0san89 avatar Feb 16 '24 22:02 Kr0san89

Can someone please approve and merge this request please ? We are actually blocked by this. Thanks !

jaykumarc avatar May 23 '24 07:05 jaykumarc

Very humble request to @jogaj @marjan-georgiev @steveblue to kindly review and merge @Kr0san89 's PR. We need to push the application to production and it will be nice to have this solution applied rather than applying workarounds for the issue. Thank you !

jaykumarc avatar May 23 '24 09:05 jaykumarc

Thank you for the contribution and apologies for the difficulty this has caused.

@swimlane/ngx-graph is now on 2.3.0. Can you please sync with master to reflect this change in the package.json?

steveblue avatar May 23 '24 22:05 steveblue

Thank you so @steveblue for your attention. @Kr0san89 Kindly requesting you to please sync your branch with master, so that Stephen can merge it. Thanks again !

jaykumarc avatar May 24 '24 07:05 jaykumarc

Thank you for the contribution and apologies for the difficulty this has caused.

@swimlane/ngx-graph is now on 2.3.0. Can you please sync with master to reflect this change in the package.json?

There was no conflict so i think rebase was not really necassary, but still i did it. Will you merge further PRs?

Kr0san89 avatar May 30 '24 18:05 Kr0san89

Thank you so much @Kr0san89 for this. @steveblue can you please do the needful now ? Thanks !

jaykumarc avatar May 31 '24 06:05 jaykumarc

Hi @steveblue @jogaj and @marjan-georgiev . Can you please complete this pull request and release new version for ngx-graph please ? We are actually stuck due to this. Thanks

jaykumarc avatar Jun 06 '24 07:06 jaykumarc