ngx-graph icon indicating copy to clipboard operation
ngx-graph copied to clipboard

Angular 15 not supported

Open tzachs opened this issue 3 years ago • 20 comments

Describe the bug Angular 15 is not supported

To Reproduce Upgrade to angular 15 using ng update

Expected behavior All checks should pass OK. Instead I'm getting npm ERR! Could not resolve dependency: npm ERR! peer @angular/animations@"10.x || 11.x || 12.x || 13.x || 14.x" from @swimlane/[email protected]

Screenshots

Demo No demo

ngx-graph version @swimlane/ngx-graph": "^8.0.2"

Additional context Add any other context about the problem here.

tzachs avatar Dec 13 '22 20:12 tzachs

For now, solved using --force

tzachs avatar Jan 01 '23 13:01 tzachs

This is a showstopper for my company as security policy dictates that we upgrade to the latest version of Angular within two months of its release.

Thanks in advance for having a look.

kgish avatar Jan 30 '23 14:01 kgish

Hi, when will this be available, I need the support for Angular 15, this is a blocker.

Malwinderkaur avatar Jan 31 '23 17:01 Malwinderkaur

👍

kgish avatar Jan 31 '23 17:01 kgish

Related PR just got merged moments ago :)

https://github.com/swimlane/ngx-graph/pull/486

jurvi avatar Feb 07 '23 17:02 jurvi

If PR is merged can we expect the release with the latest changes,this still stays the blocker.

Malwinderkaur avatar Feb 13 '23 16:02 Malwinderkaur

@jurvi can you please help us? I do see the commit in master but I don't see a new package with that commit. How can we get the new package?

tzachs avatar Feb 13 '23 20:02 tzachs

:+1:

kgish avatar Feb 13 '23 20:02 kgish

When will the issue with Angular 15 be resolved. Currently it breaks on creating transition.

vdesai007 avatar Feb 15 '23 00:02 vdesai007

@jurvi can you please help us? I do see the commit in master but I don't see a new package with that commit. How can we get the new package?

I am not affiliated with the package in any way, just commenting things I see here. :) I am also eagerly waiting for the release.

@marjan-georgiev is the wielder of power here I believe.

jurvi avatar Feb 15 '23 07:02 jurvi

Angular 15 with 8.0.3 breaks with following error

ERROR TypeError: linkSelection.attr(...).transition is not a function
        at swimlane-ngx-graph.mjs:1785:22
        at Array.map (<anonymous>)
        at QueryList.map (core.mjs:22857:30)
        at GraphComponent.redrawLines (swimlane-ngx-graph.mjs:1779:27)
        at NodeComponent.updateGraph (node.component.ts:116:13)
        at node.component.ts:81:12
        at timer (zone.js:2405:41)
        at _ZoneDelegate.invokeTask (zone.js:406:31)
        at Object.onInvokeTask (core.mjs:26218:33)
        at _ZoneDelegate.invokeTask (zone.js:405:60)

It will be great, if someone can comment on

  • Is this issue tracked and any plan date for release ?

nawnitraman avatar Feb 15 '23 14:02 nawnitraman

Angular 15 with 8.0.3 breaks with following error

ERROR TypeError: linkSelection.attr(...).transition is not a function
        at swimlane-ngx-graph.mjs:1785:22
        at Array.map (<anonymous>)
        at QueryList.map (core.mjs:22857:30)
        at GraphComponent.redrawLines (swimlane-ngx-graph.mjs:1779:27)
        at NodeComponent.updateGraph (node.component.ts:116:13)
        at node.component.ts:81:12
        at timer (zone.js:2405:41)
        at _ZoneDelegate.invokeTask (zone.js:406:31)
        at Object.onInvokeTask (core.mjs:26218:33)
        at _ZoneDelegate.invokeTask (zone.js:405:60)

It will be great, if someone can comment on

  • Is this issue tracked and any plan date for release ?

Hi, workaround for this one is if you install d3-transition v1.1.3 in your project .

Malwinderkaur avatar Feb 15 '23 15:02 Malwinderkaur

Malwinderkaur

Thanks for the workaround. It worked for us. Still waiting for proper version of ngx-graph for angular 15 compatibility. Any update on the next release will be very helpful.

nawnitraman avatar Feb 17 '23 15:02 nawnitraman

@marjan-georgiev Can you please update us on the plan of fixing the angular 15 compatibility issue ?

nawnitraman avatar Feb 25 '23 23:02 nawnitraman

@Malwinderkaur, @marjan-georgiev

Any idea when can we have the angular 15 compatibility issue resolved. We cannot proceed with deployments on other environments until we have this issue resolved.

vdesai007 avatar Mar 01 '23 19:03 vdesai007

Hi @vdesai007 I am also waiting for the release, I myself an not affiliated with this package

Malwinderkaur avatar Mar 01 '23 21:03 Malwinderkaur

+1 Thanks!

conan747 avatar Mar 24 '23 22:03 conan747

Hi guys,

Angular 16 is out now, so I think it would be worth looking into supporting it too if you plan on making a new release.

bsarkadi avatar May 05 '23 08:05 bsarkadi

Having it included into an Angular 16 Project, looks like it is working as before. So i think we could extend it.

Kr0san89 avatar May 16 '23 20:05 Kr0san89

Ping! When to expect this change being released?

amelnikoff avatar Jun 08 '23 08:06 amelnikoff