(select) event emitter conflicts with DOM Event.
I'm submitting a ... (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter
Current behavior
This library is using EventEmitters named after the select DOM Event (see here) When using a custom header (with a text input to filter rows for instance), it conflicts with basic DOM behavior (ie: double click to select all the text of the input).
Expected behavior
We should not use the same names that native DOM Events
Reproduction of the problem
http://plnkr.co/edit/7zAbklltoJWoCbN1btUL?p=info
What is the motivation / use case for changing the behavior?
Conflicts with native DOM Events names should be avoided.
Please tell us about your environment:
- Table version: 9.3.1
- Angular version: 4.3.3
- Browser: all
- Language: all
EDIT: relates to #757
Perhaps we should rename the event. Do you have any suggestions?
I can fix my own implementation that would stop the propagation of the select event.
I understand that the select keyword seems suited for that case, and I'm not sure overriding native events name is a good idea.
Renaming the event will lead to a breaking-change (and we need to find a replacement name), so I guess it's a trade-off.
Hi! Same problem here
Hello there! I'd like to suggest creating a new 'rowSelect' event while deprecating the old 'select' event. This way, we'll have two equivalent events, avoiding any breaking changes and providing a solution to this issue