ngx-datatable
ngx-datatable copied to clipboard
swimlane
Adapt RxJS peer dependency version to allow clients to use v6 or v7 at will with Angular 13
What kind of change does this PR introduce? (check one with "x")
- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Other... Please describe:
**What is the current behavior? Users switching to Angular 13+ and RxJS v7 cannot install this library because of version conflicts: Ngx-Datatable uses RxJS v6. Basically all mentioned here: #2087, #2080, #2073, #2042
What is the new behavior?
Loosen the peer dependency for RxJS so that clients can decide which version to use: v6 or v7. The RxJS breaking-changes from v7 don't affect Ngx-Datatable. Only a couple of lines needed to be fixed, but technically not related to the new RxJS version but to better type checks . You can try it out by changing directly the version to use in the package.json.
Does this PR introduce a breaking change? (check one with "x")
- [ ] Yes
- [X] No
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I didn't include the package-lock.jsonfile cause I have another version of NPM, so I prefer you have a look on this and re-generate it. I've tested these changes with the 2 versions of RxJS separately: v6 and v7
So with this, you can define in the main package.json the version RxJS that you like, it does not affect the library itself (cause it's a peer dependency).
You could for example keep on using RxJS v6 for Angular 13, and when moving forward to Angular 14 then update it to RxJS v7.
The main pain point here for all devs is actually Angular 13, because that version can use either version of RxJS.
Seems to no longer be maintained? perhaps we need someone to maintan a working fork..
Seems to no longer be maintained? perhaps we need someone to maintan a working fork..
I understand your frustration. This project is maintained but for now we need to continue to publish a ng12 compatible version.
@Hypercubed how is this maintained when the last published version on npm was a year ago? Maintenance for angular-related projects usually means supporting new versions of angular.
I understand your frustration. This project is maintained but for now we need to continue to publish a ng12 compatible version.
@Hypercubed Why can't a new version be released that supports 13 and 14 - while keeping around the 12 version?
I understand your frustration. This project is maintained but for now we need to continue to publish a ng12 compatible version.
@Hypercubed Why can't a new version be released that supports 13 and 14 - while keeping around the 12 version?
As you can see we are already behind on maintaining this project (and several more), supporting two versions of each will double that.
Please prio angular 14 support. If people upgrades their angular project i dont think they choose 12 over 14+.
As you can see we are already behind on maintaining this project (and several more), supporting two versions of each will double that.
Hi @Hypercubed. Can you elaborate on the additional constraints of supporting 2 different versions, and how that'd be any different than supporting ng 12 and ng <12? This project is clearly used and loved by many of open-source enthusiasts and a lot of us are willing to contribute to keep this going. Just let us know how we can help and we'll find a way...
This is a blocker for our team too. If a 14-compatible version isn't released, we may need to join with whoever may offer an updated fork of this package
This comment mentions a fork at siemens/ngx-datatable. This has already a few thousand downloads a week on npm. It’s currently at v21 with support for Angular13, but it seems to be actively maintained.
@Hypercubed @surya-pabbineedi Thank you for the merge! Just bringing this question to your attention ^
