ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

Upgrade rxjs dependency to version 7

Open srudin opened this issue 2 years ago • 10 comments

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[X ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

Including ngx-datatable dependency requires downgrade of rxjs to v6 or usage of --legacy-peer-deps flag.

Expected behavior

rxjs v7 can be used with default npm install command.

Reproduction of the problem

Create project with rxjs v7 dependency, add ngx-datatable v20 dependency, run npm install.

What is the motivation / use case for changing the behavior?

Stay up to date without workarounds.

Please tell us about your environment:

Not important here, I think.

  • Table version: v20

  • Angular version: v13

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ] all

  • Language: [all | TypeScript X.X | ES6/7 | ES5] all

srudin avatar Mar 16 '22 06:03 srudin

+1

ge65cer avatar Apr 25 '22 12:04 ge65cer

+1

FlavioSantoro92 avatar May 17 '22 13:05 FlavioSantoro92

+1

l-moveshelf avatar Jun 16 '22 08:06 l-moveshelf

+1

aIbarrab avatar Jun 30 '22 20:06 aIbarrab

+1

darkoxv88 avatar Jul 01 '22 17:07 darkoxv88

+1

gevorgav avatar Jul 22 '22 13:07 gevorgav

https://www.npmjs.com/package/@boring.devs/ngx-datatable (Forked) stackblitz

Mooeeezzzz avatar Aug 05 '22 17:08 Mooeeezzzz

+1

fpfcarvalho avatar Aug 24 '22 14:08 fpfcarvalho

+1

maxcl10 avatar Aug 30 '22 08:08 maxcl10

I've submitted this PR #2108, hopefully that will unblock us to move forward with Angular 13 + Ivy.

christophercr avatar Sep 05 '22 11:09 christophercr

I think this was solved meanwhile. At least I was able to remove the legacy flag and it still works.

srudin avatar Feb 03 '23 03:02 srudin