ngx-datatable
ngx-datatable copied to clipboard

Published 20 hours ago •

Reame
Issues

Upgrade rxjs to ^7.4.0

Open bahizi opened this issue 3 years ago • 19 comments

re: #2073, #2042

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) Since the upgrade to angular 13, installing the package warns that one needs to install ^[email protected] when one already has [email protected], which is what angular 13+ now runs on.

What is the new behavior? Now that we've upgraded the package to support rxjs@^7.4.0, Angular 13+ users shouldn't see false positive warnings when installing the package.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Feb 20 '22 17:02 bahizi

+1

Mar 17 '22 12:03 SwissKerim

is this going to be merged?

Mar 17 '22 14:03 alpha2k-io

please merge it asap

Mar 20 '22 15:03 hexdecimal16

+1

Mar 27 '22 08:03 Kolezhniuk

+1

Mar 31 '22 13:03 SwissKerim

+1

Apr 02 '22 21:04 Cvijo

Please merge

Apr 12 '22 07:04 user23022

+1. Needed for using ngx-datatables with latest versions of Angular.

Apr 14 '22 07:04 alvaromartmart

Need this please. Also seems the peer dep is still ng11?

Apr 19 '22 09:04 DianSSIE

Need this please. Also seems the peer dep is still ng11?

you can use --force to install it, but test it before going productive. For me it doesn't break.

Apr 23 '22 13:04 SwissKerim

Please merge

Jul 12 '22 07:07 GiuseppePennisi

+1

Jul 13 '22 09:07 TheCyberAlchemist

+1

Jul 15 '22 05:07 shayanhussaini

Hi Team,

Please merge this PR ASAP. Lot of people are waiting for this update it seems.

Jul 18 '22 05:07 jessanth

Hi Team,

Please merge this PR ASAP. Lot of people are waiting for this update it seems.

At this point, I honestly believe there's no "Team" behind this anymore. This project seems abandoned by maintainers.

Jul 18 '22 06:07 alvaromartmart

Any update here?

Jul 20 '22 17:07 rina-maslova

https://www.npmjs.com/package/@boring.devs/ngx-datatable (Forked) stackblitz

Aug 05 '22 17:08 Mooeeezzzz

Can this be merged?

Aug 09 '22 14:08 mkincyan

Please find some time to merge 👍

Sep 07 '22 10:09 SeanHasson