ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

Add all components/directives to module exports

Open yusijs opened this issue 3 years ago • 2 comments

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [X] Other... Please describe: See under "Other information"

What is the current behavior? (You can also link to an open issue here) All components and directives are not exported

What is the new behavior? All components and directives are exported

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [X] No

Other information:

Functionally this makes no difference for consumers of the library. However, we are building some features on top of this table that are very specific to our usecase. In other words, getting our changes into this project is not feasible. We're unable to build our features on top of this table without cloning the repo into our own code. Obviously this is not a good solution in the long-term. By exporting the components, we're able to reuse everything from this library and only override the ones we need. Without exporting them the components are unknown to angular.

yusijs avatar Jan 24 '22 12:01 yusijs

Hii , Is anyboday working on it. if you don't mind i want to fix this one. As I see 9 of 2 completed issue headline.

Piyush132000 avatar Feb 26 '22 04:02 Piyush132000

The pr is done, but need someone from swimlane to look at it.

yusijs avatar Feb 26 '22 09:02 yusijs