ngx-datatable Browser resize distorts ngx-datatable when used with material tabs

Browser resize distorts ngx-datatable when used with material tabs

Open sheiidan opened this issue 5 years ago • 21 comments

What kind of change does this PR introduce? (check one with "x")

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) This PR fixes the datatable bug which usually occurs when you put datatable inside Material Tabs and then you resize the window. In such case, the column widths will get distorts (in Force mode) since the visibilityObserver directive has a bug - it raises the visibility change event too early and as a result the width is too small

What is the new behavior? visibilityObserver directive is now use visibilityService to provide the visibilityChange event. visibilityService is using Intersection Observer API in case the browser supports it. Otherwise it fallback to the current implementation. In case of old browser I recommend to use a pollyfill for Intersection Observer API instead of falling back to the current buggy implemtation

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information: Fixes #1325 Fixes #1165 Fixes #1526 Fixes #923

I also added a Demo section for Material Tabs

Sep 22 '18 21:09 sheiidan

When can we expect this PR to get in? This repo has lots of issues opened which this PR addresses

Oct 17 '18 18:10 sheiidan

Is it possbile to merge this resolution? We have a performance problem that we can't resolve unitl this PR.

Thanks

Nov 09 '18 08:11 astalegale

When can we expect this to be merged?

Nov 15 '18 09:11 Broeils

I think I'm hitting the same issue and am also waiting on this to be merged.

Jan 08 '19 22:01 adamkasztenny

Anybody has an idea when this will be merged?

Jan 09 '19 11:01 chsami

Correct me if i'm wrong, but this is not related to material tabs, but instead related to the table having problems with settings the width of the columns when the table is not visible, right?

I am also struggling with this atm. I wonder if this pull fixed the issues i'm seeing too.

Feb 12 '19 15:02 Moulde

Any idea when this fix will get merged? And if not soon, any workarounds?

Mar 04 '19 11:03 oneEyedSunday

Hi Guys, can anyone merge this pull request?

Mar 07 '19 08:03 ngobaut

Hi, Can anyone please merge this?

Mar 11 '19 17:03 kaushalndesai23

Any update to this @marjan-georgiev?

Apr 16 '19 10:04 DanielMcAssey

@marjan-georgiev Would be great to see this merged

Apr 18 '19 22:04 abney317

Can this please be merged!

Apr 25 '19 23:04 jackkettle

@marjan-georgiev

Why can't this pr be merged and released? This is an annoying issue.

Jun 12 '19 20:06 kthomas182

That's something id like to know too. I don't exactly think this is still actively maintained tho. I've had to use a forceResize method

On Wed, 12 Jun 2019, 21:27 Kyle, [email protected] wrote:

@marjan-georgiev https://github.com/marjan-georgiev

Why can't this pr be merged and released? This is an annoying issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/swimlane/ngx-datatable/pull/1561?email_source=notifications&email_token=AHDNOO3HMQQMDI4MG4XX4ETP2FL25A5CNFSM4FWV2DKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRWPLQ#issuecomment-501442478, or mute the thread https://github.com/notifications/unsubscribe-auth/AHDNOOZETZ56CDD4YKF6OILP2FL25ANCNFSM4FWV2DKA .

Jun 12 '19 20:06 oneEyedSunday

Hi, this has been a very long-time persisting issue. Please update on the fix as soon as possible. Thanks