ngx-charts icon indicating copy to clipboard operation
ngx-charts copied to clipboard

Published 20 hours ago • verified publisher icon swimlane

Add bar-max-width for vertical-bar-chart

Open tomguilbault opened this issue 6 years ago • 29 comments

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) The bars in a vertical bar chart always span the entire width of the chart. even when there is only one bar, which can be aesthetically displeasing

What is the new behavior? When the new [barMaxWidth] is added to the chart, no single bar will be wider than the supplied value.
If the total of all bars is larger than the view port or a value is not supplied, the normal width logic is used.

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information: Issue #831

tomguilbault avatar Jul 02 '18 22:07 tomguilbault

This PR looks very useful. Any chances to merge it?

anton-white avatar Dec 23 '18 10:12 anton-white

Any update on this?

abdullahsaleem93 avatar Jan 09 '19 09:01 abdullahsaleem93

Will this be merged anytime soon?

ol2ka avatar Feb 01 '19 14:02 ol2ka

We are also need this feature, can you merge it and add it also to horizontal bar?

obsd avatar Feb 06 '19 11:02 obsd

Any update for this issue? I would need this feature as well!

leomayer avatar Apr 08 '19 12:04 leomayer

please can you solve this issue??

issamalshamaly avatar Jul 06 '19 17:07 issamalshamaly

Any update on this merge request?

sanjaykumarns avatar Aug 26 '19 12:08 sanjaykumarns

any updates, please can finish this issue as possible as can?

issamalshamaly avatar Sep 05 '19 14:09 issamalshamaly

Hello guys any good news about that PR ?

HDaghash avatar Oct 02 '19 06:10 HDaghash

Is this coming soon? This would be a really great feature!

alaskandan avatar Nov 02 '19 00:11 alaskandan

< would also love this enhancement!

alaskandan avatar Nov 04 '19 16:11 alaskandan

Is there any news on this?

Would love to have this.

wesleyvdkop avatar Nov 25 '19 12:11 wesleyvdkop

Any update on this?

MikeG96 avatar Dec 23 '19 19:12 MikeG96

Hey, any feedback on this? the feature is really needed!!!

ixshel avatar Feb 04 '20 03:02 ixshel

Is there any work around for this? The bars are almost comically wide and this PR has been left open for 2 years.

perrosen avatar Feb 17 '20 05:02 perrosen

Still no news for this PR? Agree with previous, it's comically wide. It's making us considering using another lib.

thesharlinator avatar Mar 07 '20 20:03 thesharlinator

any update on this? I would like this feature for vertical stacked bar charts as well.

martheli avatar Apr 29 '20 16:04 martheli

Any updates on this issue?

renemadsen avatar May 27 '20 12:05 renemadsen

any update or work around for this?

martheli avatar Jun 26 '20 22:06 martheli

Hi @tomguilbault do you have time to fix the conflict ? Otherwise I can help.

vcanuel avatar Sep 05 '20 12:09 vcanuel

Is anyone actively maintaining this? If not, I am going for fork the whole project and do what needs to be done.

aaronscribner avatar Oct 22 '20 17:10 aaronscribner

Hi Team,

We must have minimum and maximum bar width feature in ngx vertical bar chart. This is crucial feature for all of us, who are using ngx so, can you please merge this PR so that people will not migrate to other charts. @aaronscribner Thanks, Siva Vempati,

vempatiforcode avatar Oct 23 '20 04:10 vempatiforcode

@rafaelsilvany @vempatiforcode I already forked this to our company repo so we can make the changes. We will submit a PR. If they want the changes, then they can have them, if not, we will continue the development on a different stream.

@tomguilbault thanks for the start on this. I will use your code as a reference for the latest fork.

The features we intend to add

  • Min bar width
  • Max bar width (which is mostly done from this PR)
  • Dynamically adjusting graph width with scrolling set for horizontal overflow (much like D3js does)
  • Option to center the data in the middle of the graph (we already do this, but in a hacky way)

aaronscribner avatar Oct 23 '20 04:10 aaronscribner

@aaronscribner Have you had any success so far? We also need this

bbrand84 avatar Nov 05 '20 13:11 bbrand84

@aaronscribner Have you had any success so far? We also need this

I have not had time to work on it as it is currently not prioritized in our sprints.

CC: @rafaelsilvany @vempatiforcode

aaronscribner avatar Dec 05 '20 16:12 aaronscribner

@danfleser This feature is priority to us so, can you please review and resolve the conflicts.

@aaronscribner

vempatiforcode avatar Dec 18 '20 02:12 vempatiforcode

@aaronscribner it's also a priority for us. So it would be very good for us if we can get this merged, either in your fork or in the original?

Any change of this being any time soon?

renemadsen avatar Dec 18 '20 08:12 renemadsen

Any new updates?

yumi-aiassets avatar Oct 24 '22 05:10 yumi-aiassets

@aaronscribner , any updates here?

tsaputo avatar Nov 28 '23 02:11 tsaputo